chore(dataobj): instrument data objects #15803
Merged
+756
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds detailed instrumentation for data objects: * Configuration information for the dataobj.Builder, which can be used to determine page and object efficiency. * Performance information about dataobj.Builder. * Current stats about the object being appended to. * Many histograms recording the distribution of data in sections, columns, and pages. To limit the number of time series per builder, these stats are not available as classic histograms. As a result, this introduces quite a few time series, around 80 per builder instance.
rfratto
force-pushed
the
dataobj-instrumentation
branch
from
95febf5 to
cf29a6c
Compare
rfratto
commented
Jan 16, 2025
| f.Var(&cfg.TargetObjectSize, prefix+"target-object-size", "The size of the target object to use for the data object builder.") | ||
| f.StringVar(&cfg.StorageBucketPrefix, prefix+"storage-bucket-prefix", "dataobj/", "The prefix to use for the storage bucket.") |
There was a problem hiding this comment.
@cyriltovena I removed the config here like we discussed to make prefixing the caller's job with a prefixed bucket.
| _ = cfg.TargetObjectSize.Set("1GB") | ||
|
|
||
| f.IntVar(&cfg.SHAPrefixSize, prefix+"sha-prefix-size", 2, "The size of the SHA prefix to use for the data object builder.") |
There was a problem hiding this comment.
(just reorganizing the lines so it's a little nicer to read)
Bucket prefix can be determined by the client by passing a prefixed bucket.
rfratto
force-pushed
the
dataobj-instrumentation
branch
from
cf29a6c to
194a13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds detailed instrumentation for data objects:
Configuration information for the dataobj.Builder, which can be used to determine page and object efficiency.
Performance information about dataobj.Builder.
Current stats about the object being appended to.
Many histograms recording the distribution of data in sections, columns, and pages. To limit the number of time series per builder, these stats are not available as classic histograms.
As a result, this introduces quite a few time series, around 80 per builder instance.