Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): max block size #14615

Closed
wants to merge 1 commit into from
Closed

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Oct 25, 2024

What this PR does / why we need it:

Max block size is not correctly enforces since we did not look at the unflushed index and blooms pages size

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts changed the title Fix max block size fix(blooms): max block size Oct 25, 2024
@salvacorts salvacorts marked this pull request as ready for review October 25, 2024 10:33
@salvacorts salvacorts requested a review from a team as a code owner October 25, 2024 10:33
@salvacorts
Copy link
Contributor Author

closing in favour of #14577

@salvacorts salvacorts closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant