Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bloom): remove unused code from blooms #14539

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Oct 18, 2024

What this PR does / why we need it:
Cleans up blooms a little by removing unused code.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
It's probably going to be easier to review this commit-by-commit rather than the entire PR at once.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@rfratto rfratto requested a review from a team as a code owner October 18, 2024 20:09
@rfratto rfratto merged commit bf54cf1 into grafana:main Oct 21, 2024
60 checks passed
@rfratto rfratto deleted the bloom-unused-code branch October 21, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants