-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mixin): Update dashboards for bloom components #14529
Conversation
8738d86
to
d62a02f
Compare
71df367
to
d869c5c
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
152937f
to
6e3d46c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few minor issues in the dashboards but otherwise LGTM. I only left my comments on the compiled-ssd mixin, but I think what I found probably applies to all copies of them.
production/loki-mixin-compiled-ssd/dashboards/loki-bloom-gateway.json
Outdated
Show resolved
Hide resolved
"refId": "B" | ||
} | ||
], | ||
"title": "Filtered series", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This panel was blank for me, while "Found/Skipped/Missing series" wasn't. Bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a bug in Loki where we don't record series any more:
sum(rate(loki_bloom_recorder_series_total{cluster="$cluster", job="$namespace/bloom-gateway", type="filtered"}[$__rate_interval]))
Does not yield anything, where else
sum(rate(loki_bloom_recorder_chunks_total{cluster="$cluster", job="$namespace/bloom-gateway", type="filtered"}[$__rate_interval]))
does
} | ||
], | ||
"title": "Disk writes", | ||
"title": "Disk reads/writes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a 12h time range, this fails with
execution: query processing would load too many samples into memory in query execution
It works with a 1h time range though. Should we change the query to load less samples?
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
What this PR does / why we need it:
Special notes for your reviewer:
Followed the instructions
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR