Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add additional validation for timeout while retrieving headers #14217

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Sep 23, 2024

What this PR does / why we need it:
Go 1.23 changed the type of error being returned in the case of a timeout while waiting for headers, as documented in this issue
Which issue(s) this PR fixes:
Fixes #14206

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner September 23, 2024 11:42
@paul1r
Copy link
Collaborator Author

paul1r commented Sep 23, 2024

progers@Pauls-MacBook-Pro gcp % /usr/local/go/bin/go version            
go version go1.22.7 darwin/arm64
progers@Pauls-MacBook-Pro gcp % /usr/local/go/bin/go test -count=1 ./...
ok  	github.com/grafana/loki/v3/pkg/storage/chunk/client/gcp	1.747s

progers@Pauls-MacBook-Pro gcp % go version
go version go1.23.1 darwin/arm64
progers@Pauls-MacBook-Pro gcp % go test -count=1 ./...
ok  	github.com/grafana/loki/v3/pkg/storage/chunk/client/gcp	1.751s

@paul1r paul1r changed the title test: Add additional validation for timeout while retrieving headers fix: Add additional validation for timeout while retrieving headers Sep 23, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul1r paul1r merged commit 8322e51 into main Sep 23, 2024
62 checks passed
@paul1r paul1r deleted the paul1r/adjust_gcs_failing_test_case_for_go_1_23 branch September 23, 2024 13:31
@paul1r paul1r added type/bug Somehing is not working as expected backport release-3.2.x labels Sep 23, 2024
loki-gh-app bot pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.2.x size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants