Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the chunk encoding correctly when creating chunk from bytes. #1420

Merged
merged 4 commits into from
Dec 14, 2019
Merged

Sets the chunk encoding correctly when creating chunk from bytes. #1420

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b297c7c
Sets the chunk encoding correctly when creating chunk from bytes.
cyriltovena Dec 14, 2019
af7ddd9
roundtrip v2 encoding tests
owen-d Dec 14, 2019
945db13
asserts encodings are nominally the same in chunks during roundtrips
owen-d Dec 14, 2019
2bc4f12
Add a line limit in case a chunk is corrupted to avoid OOM.
cyriltovena Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
asserts encodings are nominally the same in chunks during roundtrips
  • Loading branch information
@owen-d
owen-d committed Dec 14, 2019
commit 945db13220c878d5a169b9f6b340543a17394ed1
1 change: 1 addition & 0 deletions pkg/chunkenc/memchunk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ func TestRoundtripV2(t *testing.T) {
populated := fillChunk(c)

assertLines := func(c *MemChunk) {
require.Equal(t, enc, c.Encoding())
it, err := c.Iterator(time.Unix(0, 0), time.Unix(0, math.MaxInt64), logproto.FORWARD, nil)
if err != nil {
t.Fatal(err)
Expand Down