Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update publish-technical-documentation-next.yml #12617

Merged
merged 2 commits into from
Apr 15, 2024
Merged

docs: Update publish-technical-documentation-next.yml #12617

merged 2 commits into from
Apr 15, 2024

Conversation

JStickler
Copy link
Contributor

@JStickler JStickler commented Apr 15, 2024 •
edited
Loading

I discovered that the workflows are still failing....

Continues #2294

What this PR does / why we need it:
Continues https://github.com/grafana/enterprise-logs/pull/2294

@JStickler JStickler requested a review from a team as a code owner April 15, 2024 12:49
@JStickler JStickler requested a review from jdbaldry April 15, 2024 12:49
@jdbaldry
Remove dependency on previously removed job
6f2c390 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
jdbaldry approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this!

@JStickler JStickler merged commit 945a0f5 into main Apr 15, 2024
11 checks passed
@JStickler JStickler deleted the JStickler-patch-1 branch April 15, 2024 13:03
@grafanabot
Copy link
Collaborator

Hello @jdbaldry!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafanabot
Copy link
Collaborator

Hello @jdbaldry!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@jdbaldry jdbaldry added type/ci type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories backport release-2.9.x backport release-3.0.x and removed missing-labels backport release-2.9.x backport release-3.0.x labels Apr 25, 2024
grafanabot pushed a commit that referenced this pull request Apr 25, 2024
@JStickler @grafana-delivery-bot
docs: Update publish-technical-documentation-next.yml (#12617)
e11df4d 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 945a0f5)
@grafanabot grafanabot mentioned this pull request Apr 25, 2024
Merged
grafanabot pushed a commit that referenced this pull request Apr 25, 2024
@JStickler @grafana-delivery-bot
docs: Update publish-technical-documentation-next.yml (#12617)
3791d0a 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 945a0f5)
@grafanabot grafanabot mentioned this pull request Apr 25, 2024
Merged
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbaldry jdbaldry jdbaldry approved these changes

Assignees
No one assigned
Labels
backport release-2.9.x backport release-3.0.x size/XS type/ci type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JStickler @grafanabot @jdbaldry