Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rules that reference no longer existing metrics #1216

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Remove rules that reference no longer existing metrics #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove rules that reference no longer existing metrics 
Signed-off-by: Joe Elliott <number101010@gmail.com>
  • Loading branch information
@joe-elliott
joe-elliott committed Oct 30, 2019
commit a0659187a4b6037655d180aec749afca09773481
38 changes: 0 additions & 38 deletions production/loki-mixin/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,44 +39,6 @@
},
],
},
{
name: 'loki_frontend_alerts',
rules: [
{
alert: 'FrontendRequestErrors',
expr: |||
100 * sum(rate(cortex_gw_request_duration_seconds_count{status_code=~"5.."}[1m])) by (namespace, job, route)
/
sum(rate(cortex_gw_request_duration_seconds_count[1m])) by (namespace, job, route)
> 10
|||,
'for': '15m',
labels: {
severity: 'critical',
},
annotations: {
message: |||
{{ $labels.job }} {{ $labels.route }} is experiencing {{ printf "%.2f" $value }}% errors.
|||,
},
},
{
alert: 'FrontendRequestLatency',
expr: |||
namespace_job_route:cortex_gw_request_duration_seconds:99quantile > 1
|||,
'for': '15m',
labels: {
severity: 'critical',
},
annotations: {
message: |||
{{ $labels.job }} {{ $labels.route }} is experiencing {{ printf "%.2f" $value }}s 99th percentile latency.
|||,
},
},
],
},
{
name: 'promtail_alerts',
rules: [
Expand Down
6 changes: 0 additions & 6 deletions production/loki-mixin/recording_rules.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ local utils = import "mixin-utils/utils.libsonnet";
utils.histogramRules('loki_request_duration_seconds', ['job']) +
utils.histogramRules('loki_request_duration_seconds', ['job', 'route']) +
utils.histogramRules('loki_request_duration_seconds', ['namespace', 'job', 'route']),
}, {
name: 'loki_frontend_rules',
rules:
utils.histogramRules('cortex_gw_request_duration_seconds', ['job']) +
utils.histogramRules('cortex_gw_request_duration_seconds', ['job', 'route']) +
utils.histogramRules('cortex_gw_request_duration_seconds', ['namespace', 'job', 'route']),
}, {
name: 'promtail_rules',
rules:
Expand Down