Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Add memberlist IPv6 support #10562

Merged
merged 16 commits into from
Oct 2, 2023

Conversation

periklis
Copy link
Collaborator

@periklis periklis commented Sep 13, 2023

What this PR does / why we need it:
Exposes the memberlist capability to run on IPv6 and dual-stack Kubernetes clusters.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@periklis periklis changed the title operator: Add support for memberlist IPv6 support operator: Add memberlist IPv6 support Sep 13, 2023
@periklis periklis marked this pull request as ready for review September 13, 2023 13:23
@periklis periklis requested review from xperimental and a team as code owners September 13, 2023 13:23
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor nits, lgtm

operator/CHANGELOG.md Outdated Show resolved Hide resolved
operator/internal/manifests/internal/config/options.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on an IPv6-only cluster and on a dual-stack IPv4/v6 cluster. Just some smaller comments.

operator/apis/loki/v1/lokistack_types.go Outdated Show resolved Hide resolved
operator/apis/loki/v1/lokistack_types.go Outdated Show resolved Hide resolved
operator/internal/manifests/config.go Outdated Show resolved Hide resolved
operator/internal/manifests/config.go Show resolved Hide resolved
operator/internal/manifests/memberlist.go Outdated Show resolved Hide resolved
operator/apis/loki/v1/v1.go Outdated Show resolved Hide resolved
operator/internal/manifests/var.go Outdated Show resolved Hide resolved
@periklis periklis merged commit 41eb82b into grafana:main Oct 2, 2023
11 checks passed
periklis added a commit to periklis/loki that referenced this pull request Oct 2, 2023
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis added a commit to periklis/loki that referenced this pull request Oct 2, 2023
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis added a commit to openshift/loki that referenced this pull request Oct 2, 2023
openshift-merge-robot added a commit to openshift/loki that referenced this pull request Oct 2, 2023
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants