Update CODEOWNERS to include logs team for grammar file #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Aug 23, 2023
matyax
reviewed
Aug 23, 2023
| @@ -8,5 +8,9 @@ | |||
| /operator/ @grafana/loki-team @periklis @xperimental | |||
| /.github/workflows/operator* @grafana/loki-team @periklis @xperimental | |||
|
|
|||
| # Logql grammar | |||
| # The observability logs team is listed as co-codeowner for grammar file. This is to receive notifications about updates, so these can be implemented in https://github.com/grafana/lezer-logql | |||
| /pkg/logql/syntax/expr.y @grafana/observability-logs @grafana/loki-team | |||
There was a problem hiding this comment.
GitHub shows an error here, even though the team exists. Is this expected?
There was a problem hiding this comment.
It is because we don't have write access to repository. I mentioned it on slack. As soon as we have it, it is going to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To keep LogQL grammar in sync with https://github.com/grafana/lezer-logql, we would like to add @grafana/observability-logs as a co-codeowner for grammar file
/pkg/logql/syntax/expr.yto get notification when this file change.