Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs script and recreate reference #10072

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:
The changes to the helm docs in PR #9974 missed out a corresponding change needed in docs/Makefile. The reference.md file was also regenerated so it's up to date now.

Which issue(s) this PR fixes:
Fixes #10069

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 26, 2023
@MichelHollands MichelHollands requested a review from a team July 26, 2023 13:30
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichelHollands MichelHollands merged commit 93b07f7 into grafana:main Jul 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for helm not upgrading in pipeline on values.yaml changes
3 participants