Skip to content

Arm and arm64 images for grafana/loki-build-image #5327

Closed

Description

Is your feature request related to a problem? Please describe.
cmd/loki/Dockerfile currently fails to build due to the absence of goyacc in the golang image it is based on.
Example: https://drone.grafana.net/grafana/loki/8355/3/3

To fix this, grafana/loki-build-image should be used instead. It is based on the same golang docker image, but has the tools required by the Makefile included. It is already used in cmd/loki/Dockerfile.debug.

Unfortunately, even though a grafana/loki-build-image based container is able to invoke goyacc from make, it cannot build arm based images.
Example: https://drone.grafana.net/grafana/loki/8426/4/3

Describe the solution you'd like
CI based arm and arm64 support for the loki-build-image container.

Describe alternatives you've considered
As a temporary measure, I am creating a PR that introduces the go tools required to build loki into cmd/loki/Dockerfile.
This duplication is likely to cause drift if left in place too long, but will unblock me until grafana/loki-build-image can be ported to arm and arm64.

Additional context
#5323
#5306
#5275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    staleA stale issue or PR that will automatically be closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions