Skip to content

[helm] test-canary template doesn't respect test.enabled flag #13124

Open

Description

Describe the bug
test-canary template only checks if Loki Canary is enabled (lokiCanary.enabled). It should also checks test.enabled.

To Reproduce

  1. Install using Helm and using a value of test.enabled: false

To fix it

# test-canary.yaml
...
{{- if and .enabled $.Values.lokiCanary.enabled }}
...

Expected behavior
If test.enabled is false, loki-helm-test should not be deploy.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: Helm

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions