Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Conversation

emcfarlane
Copy link

No description provided.

@foxdalas
Copy link

@afking Nice fix. Big thanks

@Sanwel
Copy link

Sanwel commented Jan 7, 2019

Have some question, not all query have 'node=$node' as selector, and I need to change it manually to 'kubernetes_node=$node'. Is there any point to make pull request with such changes?

@emcfarlane
Copy link
Author

@Sanwel which queries are you having issues with?

@neufeldtech
Copy link

Any word on the status of getting this merged into master? It would be great to see the node dashboard fixed up for the node-exporter 0.16.0

@CiaranCurran
Copy link

@afking thanks for the fix, however, I am still having same issue mentioned by @Sanwel

In the k8s cluster dashboard the cluster disk usage and cluster disk capacity panels the node=$node query does not work as the nodes are referenced by 'kuberenetes_node' instead, which I have to set manually.

@phedoreanu
Copy link

phedoreanu commented Apr 2, 2019

@afking It would be great to have this merged!

Copy link

@klaud81 klaud81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's look good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants