fix: preserve camelCase metadata in machine-readable summaries#6079
Open
immanuwell wants to merge 1 commit into
Open
fix: preserve camelCase metadata in machine-readable summaries#6079immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix machine-readable summary metadata keys.
Repro:
printf 'export default function() {}\n' > script.jsk6 run --summary-export=summary.json --new-machine-readable-summary=true script.jsBefore:
metadata.generated_atmetadata.k6_versionAfter:
metadata.generatedAtmetadata.k6VersionWhy?
This is easy to hit on a plain local run, no cloud bits or quotas involved.
The new summary was going through JS as Go structs, so Sobek rewrote the field names to snake_case. Bit sneaky.
This switches that path to JSON-compatible maps and adds tests for
handleSummary(data)and CLI export.Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Related PR(s)/Issue(s)
Closes #6004