TestPageOnResponse: Fail fast on error
#5216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rMaxiQp
requested review from
AgnesToulet and
mstoykov
and removed request for
a team
rMaxiQp
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
rMaxiQp
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
AgnesToulet
approved these changes
Oct 9, 2025
Contributor
AgnesToulet
left a comment
AgnesToulet
left a comment
There was a problem hiding this comment.
Thank you for your contribution, I think this change makes sense 👍
rMaxiQp
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
rMaxiQp
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
ankur22
added a commit
that referenced
this pull request
Nov 5, 2025
ankur22
added a commit
that referenced
this pull request
Nov 5, 2025
ankur22
added a commit
that referenced
this pull request
Nov 10, 2025
* Add v1.4.0 release notes * Add inanc's and external contributor changes * thank elmiringos * clarify 5322 slightly * Add Agnes' changes * OpenTelemetry graduation * Additional breaking change for OTel output * Add Joan's changes * Add auto extension resolution changes * Add ankur22's changes * Remove template bits from release note * Add dependency PR changes * Add #5159 to release note * Add #5216 to the release note * Add external contribution for #5216 * Add winGet support to release note * Add google/uuid update to release note * Add more renovate changes to release note * Add more dep updates to release note * Add missing comma * Other changes by me (@mstoykov) * fix doc links * Remove duplicate issues * Add remaining issues to release notes * Apply suggestions from code review Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * fix 5307 code block * Update release notes/v1.4.0.md Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * Update release notes/v1.4.0.md Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * docs: document k6/x/dns official support * docs: add xk6-dns extension link to release notes * Remove roadmap from release notes --------- Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: AgnesToulet <35176601+AgnesToulet@users.noreply.github.com> Co-authored-by: codebien <2103732+codebien@users.noreply.github.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> Co-authored-by: Mihail Stoykov <M.Stoikov@gmail.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Co-authored-by: oleiade <theo@crevon.me>
rMaxiQp
pushed a commit
to rMaxiQp/k6
that referenced
this pull request
Nov 11, 2025
* Add v1.4.0 release notes * Add inanc's and external contributor changes * thank elmiringos * clarify 5322 slightly * Add Agnes' changes * OpenTelemetry graduation * Additional breaking change for OTel output * Add Joan's changes * Add auto extension resolution changes * Add ankur22's changes * Remove template bits from release note * Add dependency PR changes * Add grafana#5159 to release note * Add grafana#5216 to the release note * Add external contribution for grafana#5216 * Add winGet support to release note * Add google/uuid update to release note * Add more renovate changes to release note * Add more dep updates to release note * Add missing comma * Other changes by me (@mstoykov) * fix doc links * Remove duplicate issues * Add remaining issues to release notes * Apply suggestions from code review Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * fix 5307 code block * Update release notes/v1.4.0.md Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * Update release notes/v1.4.0.md Co-authored-by: Inanc Gumus <inanc.gumus@grafana.com> * docs: document k6/x/dns official support * docs: add xk6-dns extension link to release notes * Remove roadmap from release notes --------- Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com> Co-authored-by: AgnesToulet <35176601+AgnesToulet@users.noreply.github.com> Co-authored-by: codebien <2103732+codebien@users.noreply.github.com> Co-authored-by: Joan López de la Franca Beltran <joanjan14@gmail.com> Co-authored-by: Mihail Stoykov <M.Stoikov@gmail.com> Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Co-authored-by: oleiade <theo@crevon.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use
requireinstead ofassertto fail fast.Why?
In case of any error on
RunAsync(),gvmay benil. It defeatsToPromise()'s input assumption, leading to a panic. Though this change does not fix the root cause, it helps to surface the actual error instead. With this change, we bring the testcase's state similar to #4307Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Related to #5124