Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It removes a few gRPC client tests.
Why?
Because by observing them running in CI, and based on what has been discussed in #3545 and #3551, it looks like these have a flaky nature that's not easy to fix, and we even have doubts about its utility, so better to remove them for now.
I also tried to replace the hard-coded certificates, as suggested in #3549, and in a similar way as in #3527, but in this case it's not as easy as that because the server we use for the these tests (
HTTPMultiBin
) heavily relies onhttptest.NewTLSServer
from Go stdlib, which manages its own set of certificates.Indeed, that's the reason why we also have to use the
example.com
domain there.So, I'd suggest to either better to discard that idea, or at the very least leave it for the future because it looks like it's going to imply a larger refactor.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
I guess it can close #3551