Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint issues in lib/fsext #3482

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix lint issues in lib/fsext #3482

merged 2 commits into from
Dec 12, 2023

Conversation

mstoykov
Copy link
Contributor

works on #769

@mstoykov mstoykov added this to the v0.49.0 milestone Nov 30, 2023
@github-actions github-actions bot requested review from codebien and oleiade November 30, 2023 16:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (856a767) 73.22% compared to head (d4b699e) 73.16%.
Report is 11 commits behind head on master.

❗ Current head d4b699e differs from pull request most recent head 327040d. Consider uploading reports for the commit 327040d to get more accurate results

Files Patch % Lines
lib/fsext/walk.go 14.28% 5 Missing and 1 partial ⚠️
output/cloud/output.go 0.00% 1 Missing and 1 partial ⚠️
api/server.go 50.00% 1 Missing ⚠️
js/compiler/compiler.go 66.66% 1 Missing ⚠️
lib/fsext/changepathfs.go 0.00% 1 Missing ⚠️
output/cloud/v1/data.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3482      +/-   ##
==========================================
- Coverage   73.22%   73.16%   -0.07%     
==========================================
  Files         267      265       -2     
  Lines       20083    20078       -5     
==========================================
- Hits        14706    14690      -16     
- Misses       4463     4470       +7     
- Partials      914      918       +4     
Flag Coverage Δ
ubuntu 73.16% <42.85%> (-0.01%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oleiade
oleiade previously approved these changes Dec 4, 2023
lib/fsext/changepathfs.go Outdated Show resolved Hide resolved
@mstoykov mstoykov merged commit 09a96af into master Dec 12, 2023
21 checks passed
@mstoykov mstoykov deleted the linterFixFSExt branch December 12, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants