Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/cloudv2: Compact histogram #3169

Merged
merged 8 commits into from
Jul 10, 2023
Merged

output/cloudv2: Compact histogram #3169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca33225
cloudv2/pbcloud: Compact histogram
codebien Jul 5, 2023
6f7548d
hdr_test: Test more edge cases
codebien Jul 5, 2023
0f676c5
cloudv2: Use a compact version for histogram
codebien Jul 6, 2023
b7cb2b3
cloudv2/integration: Test updated accordingly
codebien Jul 6, 2023
e7bee24
Address request changes
codebien Jul 7, 2023
976a8ff
Test polishing
codebien Jul 7, 2023
1ec8c97
Use the constructor
codebien Jul 7, 2023
4f49f36
Sort the buckets during the Proto generation
codebien Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use the constructor
  • Loading branch information
@codebien
codebien committed Jul 7, 2023
commit 1ec8c978e2b5af6fe35a8eab65de888d3af4b1f1
10 changes: 1 addition & 9 deletions output/cloud/expv2/sink_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package expv2

import (
"math"
"testing"

"github.com/stretchr/testify/assert"
Expand All @@ -17,14 +16,7 @@ func TestNewSink(t *testing.T) {
{metrics.Counter, &counter{}},
{metrics.Gauge, &gauge{}},
{metrics.Rate, &rate{}},
{
metrics.Trend,
&histogram{
Buckets: map[uint32]uint32{},
Max: -math.MaxFloat64,
Min: math.MaxFloat64,
},
},
{metrics.Trend, newHistogram()},
}
for _, tc := range tests {
assert.Equal(t, tc.exp, newMetricValue(tc.mt))
Expand Down