Skip to content

Upgrade to Go 1.17 #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Upgrade to Go 1.17 #2156

merged 4 commits into from
Oct 5, 2021

Conversation

b5710546232
Copy link
Contributor

Description of the changes

  • Upgrade go version to 1.17

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can you also re-enable test-prev now and make that CI task use Go 1.16, now that we'll use 1.17 for everything else:

go-version: [1.15.x]
platform: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.platform }}
if: github.ref == 'skipped' #TODO: re-enable this when Go 1.17 comes out?

We had disabled it previously because we required 1.16 for go:embed.

@na-- na-- added this to the v0.35.0 milestone Oct 5, 2021
na--
na-- previously approved these changes Oct 5, 2021
Copy link
Contributor

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@e0d8d93). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 78582a1 differs from pull request most recent head 32b2314. Consider uploading reports for the commit 32b2314 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2156   +/-   ##
=========================================
  Coverage          ?   72.74%           
=========================================
  Files             ?      184           
  Lines             ?    14571           
  Branches          ?        0           
=========================================
  Hits              ?    10599           
  Misses            ?     3330           
  Partials          ?      642           
Flag Coverage Δ
ubuntu 72.68% <0.00%> (?)
windows 72.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d8d93...32b2314. Read the comment docs.

mstoykov
mstoykov previously approved these changes Oct 5, 2021
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the change 🙇

@mstoykov
Copy link
Contributor

mstoykov commented Oct 5, 2021

@b5710546232 very sorry about that, but it appears some months ago I decided to try to enable parallel testing under windows and as the test kept passing I decided it now works 🎉.

But now looking at this it's obvious that I did the change in the disabled test-prev 🤦 so if you can please git revert 4c3571a75 and push again ... very sorry.

@b5710546232
Copy link
Contributor Author

@b5710546232 very sorry about that, but it appears some months ago I decided to try to enable parallel testing under windows and as the test kept passing I decided it now works 🎉.

But now looking at this it's obvious that I did the change in the disabled test-prev 🤦 so if you can please git revert 4c3571a75 and push again ... very sorry.

No problem.

@mstoykov mstoykov merged commit 8ec4e50 into grafana:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants