-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Upgrade to Go 1.17 #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Go 1.17 #2156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Can you also re-enable test-prev
now and make that CI task use Go 1.16, now that we'll use 1.17 for everything else:
Lines 69 to 72 in e0d8d93
go-version: [1.15.x] | |
platform: [ubuntu-latest, windows-latest] | |
runs-on: ${{ matrix.platform }} | |
if: github.ref == 'skipped' #TODO: re-enable this when Go 1.17 comes out? |
We had disabled it previously because we required 1.16 for go:embed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #2156 +/- ##
=========================================
Coverage ? 72.74%
=========================================
Files ? 184
Lines ? 14571
Branches ? 0
=========================================
Hits ? 10599
Misses ? 3330
Partials ? 642
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thanks for the change 🙇
@b5710546232 very sorry about that, but it appears some months ago I decided to try to enable parallel testing under windows and as the test kept passing I decided it now works 🎉. But now looking at this it's obvious that I did the change in the disabled |
This reverts commit 4c3571a.
No problem. |
Description of the changes