Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase readiness and liveness probe timeouts, introduce an initial delay #438

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Increase readiness and liveness probe timeouts, introduce an initial delay #438

wants to merge 1 commit into from

Commits on Aug 13, 2024

  1. Increase readiness and liveness probe timeouts, introduce an initial … 

    …delay

Currently the default timeout of 1 second and no initial delay is applied
to the probes of the runner pods. Depending on the startup time this
can cause random Pod errors causing a whole TestRun to fail.

At some point it might also make sense to introduce a startupProbe to cover
the longer initial startup time a K6 instance / pod might need instead of ever
increasing the runtime liveness and readiness checks.

Since having the Liveness and Readiness checks be just the same makes not much
sense, as the liveness check fail will cause the container to be restarted,
this change also splits up those two tests, to allow for more individual
configuration, be it timers or what is actually checked.

Fixes grafana#306

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
    @frittentheke
    frittentheke committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0ed7572 View commit details
    Browse the repository at this point in the history