fix: duplicate job should be an error only after wait period

grafana · Feb 1, 2024 · b1a5e24 · b1a5e24
1 parent 1ddf97c
commit b1a5e24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/controllers/k6_create.go b/controllers/k6_create.go
@@ -88,8 +88,9 @@ func createJobSpecs(ctx context.Context, log logr.Logger, k6 v1alpha1.TestRunI,
 		log.Info(err.Error())
 
 		// is it possible to implement this delay with resourceVersion of the job?
-		t, _ := v1alpha1.LastUpdate(k6, v1alpha1.CloudTestRun)
-		if time.Since(t).Seconds() <= 30 {
+		t, condUpdated := v1alpha1.LastUpdate(k6, v1alpha1.CloudTestRun)
+		// if condition has not been updated yet or has been updated very recently
+		if !condUpdated || time.Since(t).Seconds() <= 30 {
 			// try again before returning an error
 			return ctrl.Result{RequeueAfter: time.Second * 10}, true, nil
 		}