Disregard K6_DISCARD_RESPONSE_BODIES
#114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This Pull Request addresses #45, namely ignoring k6's
discardResponseBodies
and always returning response bodies obtained from jslib-aws HTTP calls.How
In this PR, we introduce a
baseRequestParams
member in theAWSClient
class, which we add to every request made by children class implementations.Using the
baseRequestParams
we set the default responseType for children implementation, allowing us to effectively disregard the http discardResponseBodies option. We can still, locally, override it where necessary, as inS3Client.getObject
, for instance.Demo
The following script:
Will display something along the lines of:
References
closes #45