Skip to content

refactor(prometheus): shard mixins over multiple configmaps #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions mixin-utils/utils.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,29 @@ local g = import 'grafana-builder/grafana.libsonnet';
}
for group in groups
],

removeRuleGroup(ruleName):: {
local removeRuleGroup(rule) = if rule.name == ruleName then null else rule,
local currentRuleGroups = super.groups,
groups: std.prune(std.map(removeRuleGroup, currentRuleGroups)),
},

removeAlertRuleGroup(ruleName):: {
prometheusAlerts+:: $.removeRuleGroup(ruleName),
},

removeRecordingRuleGroup(ruleName):: {
prometheusRules+:: $.removeRuleGroup(ruleName),
},

overrideAlerts(overrides):: {
local overrideRule(rule) =
if 'alert' in rule && std.objectHas(overrides, rule.alert)
then rule + overrides[rule.alert]
else rule,
local overrideInGroup(group) = group { rules: std.map(overrideRule, super.rules) },
prometheusAlerts+:: {
groups: std.map(overrideInGroup, super.groups),
},
},
}
4 changes: 2 additions & 2 deletions prometheus-ksonnet/lib/prometheus.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ prometheus_mixins {
_config+:: $._config { name: name },
_images+:: $._images,
mixins:: $.mixins,
prometheusRules:: $.prometheusRules,
prometheusAlerts:: $.prometheusAlerts,
prometheusRules:: if std.objectHas($, 'prometheusRules') then $.prometheusRules else {},
prometheusAlerts:: if std.objectHas($, 'prometheusAlerts') then $.prometheusAlerts else {},
prometheus_config+:: $.prometheus_config,

},
Expand Down
86 changes: 69 additions & 17 deletions prometheus/mixins.libsonnet
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
{
local k = import 'ksonnet-util/kausal.libsonnet';

(import 'config.libsonnet')
+ {
local _config = self._config,

mixins+:: {
base+: {
prometheusAlerts+: {
Expand Down Expand Up @@ -58,21 +63,68 @@
prometheusRules+:: {},
},

prometheusAlerts::
std.foldr(
function(mixinName, acc)
local mixin = $.mixins[mixinName] + emptyMixin;
acc + mixin.prometheusAlerts,
std.objectFields($.mixins),
{}
),
withMixinsConfigmaps(mixins):: {
local configMap = k.core.v1.configMap,
prometheus_config_maps_mixins+: [
local mixin = mixins[mixinName] + emptyMixin;
local prometheusAlerts = mixin.prometheusAlerts;
local prometheusRules = mixin.prometheusRules;
configMap.new(
std.strReplace('%s-%s-mixin' % [_config.name, mixinName], '_', '-')
)
+ configMap.withData({
'alerts.rules': k.util.manifestYaml(prometheusAlerts),
'recording.rules': k.util.manifestYaml(prometheusRules),
})
for mixinName in std.objectFields(mixins)
],

prometheus_config+: {
rule_files+:
std.foldr(
function(mixinName, acc)
acc + [
'mixins/%s/alerts.rules' % mixinName,
'mixins/%s/recording.rules' % mixinName,
],
std.objectFields(mixins),
[]
),
},

prometheusRules::
std.foldr(
function(mixinName, acc)
local mixin = $.mixins[mixinName] + emptyMixin;
acc + mixin.prometheusRules,
std.objectFields($.mixins),
{},
),
prometheus_config_mount+::
std.foldr(
function(mixinName, acc)
acc
+ k.util.configVolumeMount(
std.strReplace('%s-%s-mixin' % [_config.name, mixinName], '_', '-'),
'%s/mixins/%s' % [_config.prometheus_config_dir, mixinName]
),
std.objectFields(mixins),
{}
),
},

// Extends legacy extension points with the mixins object, adding
// the alerts and recording rules to root-level. This functions
// should be applied if you want to retain the legacy behavior.
withMixinsLegacyConfigmaps(mixins):: {
prometheusAlerts+::
std.foldr(
function(mixinName, acc)
local mixin = mixins[mixinName] + emptyMixin;
acc + mixin.prometheusAlerts,
std.objectFields(mixins),
{}
),

prometheusRules+::
std.foldr(
function(mixinName, acc)
local mixin = mixins[mixinName] + emptyMixin;
acc + mixin.prometheusRules,
std.objectFields(mixins),
{},
),
},
}