Refactor windows observ lib to use signals #1455
Open
+1,768
−783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-zhuravlev
requested review from
rgeyer,
aditya-konarde,
gaantunes and
Dasomeone
v-zhuravlev
force-pushed
the
windows-signals-proto
branch
from
0c00afc to
c0b9c25
Compare
gaantunes
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor windows observ lib to use signals.
This is prestep to support multiple metrics 'sources'/namings , see prometheus-community/windows_exporter#1596
Note to reviewer.
By carefully examining diff in dashboards_out/promethes_out folders we can be sure that no user facing changes are made and output remained the same. Only irrelevant to the output changes can be seen.