Skip to content

feat: add netflow-mixin #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

feat: add netflow-mixin #1452

merged 2 commits into from
Jun 20, 2025

Conversation

theSuess
Copy link
Contributor

This mixin is intended to be used with tools like
ktranslate but will also work with other tooling, as long as the metrics conform to the networking semantic conventions.

@theSuess theSuess requested a review from a team as a code owner June 18, 2025 10:57
@theSuess theSuess force-pushed the feat/netflow-mixin branch from 3ff3c72 to 942a148 Compare June 18, 2025 11:05
@theSuess theSuess requested a review from v-zhuravlev June 18, 2025 11:13
Copy link
Contributor

@v-zhuravlev v-zhuravlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only datasource filter should be removed.

+ g.dashboard.withTimezone($._config.dashboardTimezone)
+ g.dashboard.withVariables([
var.datasource.new('prometheus_datasource', 'prometheus')
+ var.datasource.withRegex('(ops|dev)-cortex')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this filter looks a bit specific.

@theSuess theSuess force-pushed the feat/netflow-mixin branch from ef794bc to 32bbbfb Compare June 20, 2025 07:09
@v-zhuravlev v-zhuravlev enabled auto-merge (squash) June 20, 2025 07:16
theSuess added 2 commits June 20, 2025 09:23
This mixin is intended to be used with tools like
[ktranslate](https://github.com/kentik/ktranslate) but will also work with other
tooling, as long as the metrics conform to the [networking semantic conventions](https://opentelemetry.io/docs/specs/semconv/registry/attributes/network/).
@theSuess theSuess force-pushed the feat/netflow-mixin branch from 32bbbfb to 1f2bdc5 Compare June 20, 2025 07:23
@v-zhuravlev v-zhuravlev merged commit 58c5ef4 into master Jun 20, 2025
10 checks passed
@v-zhuravlev v-zhuravlev deleted the feat/netflow-mixin branch June 20, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants