MSSQL Modernization #1450
MSSQL Modernization #1450
Conversation
mssql-mixin/rows.libsonnet
Outdated
| database: | ||
| [ | ||
| g.panel.row.new('Database'), | ||
| this.grafana.panels.databaseWriteStallDurationPanel | ||
| + g.panel.timeSeries.gridPos.withW(12), | ||
| this.grafana.panels.databaseReadStallDurationPanel | ||
| + g.panel.timeSeries.gridPos.withW(12), | ||
| this.grafana.panels.transactionLogExpansionsPanel | ||
| + g.panel.timeSeries.gridPos.withW(24), | ||
| ], | ||
| }, |
There was a problem hiding this comment.
best if row panels are added not as array but inside
g.panel.row.withPanels() function. This way it is possible to toggle rows collapsed/uncollapsed.
example:
https://github.com/grafana/jsonnet-libs/blob/master/kafka-observ-lib/rows.libsonnet#L25-L33.
and then:
https://github.com/grafana/jsonnet-libs/blob/master/kafka-observ-lib/dashboards.libsonnet#L33-L52
There was a problem hiding this comment.
Couple minor comments but overall this looks great to me!
Admittedly a bit rusty on this what with PTO and all so leaving final approval up to @v-zhuravlev
There was a problem hiding this comment.
Missing .json filetype on this and the mssql_overview files
| "keepTime": true, | ||
| "title": "MSSQL Overview", | ||
| "type": "link", | ||
| "url": "/d/mssql_mssql_overview" |
There was a problem hiding this comment.
I know this is generated, but it feels like a weird change to have mssql twice in the URL?
|
@v-zhuravlev just curious, do you think we should just default to using signals for this PR as well? I think the API is nice to use and gives us more flexibility probably moving forward. |
yes, it would be great using Signals where possible. I also see asTarget() as first transitional step for easier migration, using asTimeSeries() and asPanelMixin(), asTable(), asTableRow() (which propogate units, value mappings from signals) are even better for panel constructions from signals, I encourage you take a look in README or other observ-libs, like kafka, jvm etc. But let's finish off Clickhouse first. |
This involves separating out the MSSQL Overview dashboard to separate logs and metrics. This would require some new screenshots.