Enhance windows observ lib with detailed alerts and add promtool tests. #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add kafka and snmp generated files
mshahzeb
approved these changes
Feb 24, 2025
Dasomeone
reviewed
Feb 24, 2025
v-zhuravlev
force-pushed
the
add-promtool
branch
from
56e36a5 to
739fe40
Compare
v-zhuravlev
force-pushed
the
add-promtool
branch
from
2839a62 to
e4be607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add windows alerts expanded descriptions. Add promtool testing in CI. And add documentation that such tests should be added for all alerts with complex queries/complex golang templates in descriptions.
Note: promtool tests in CI would fire when target branch is switched to master.