Skip to content

feat: add serviceId label to csp-mixin alerts #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

anaivanov
Copy link
Contributor

@anaivanov anaivanov commented Feb 20, 2025

It adds a new label prop serviceId for each alert.

Relates to https://github.com/grafana/grafana-csp-app/issues/438

@anaivanov anaivanov marked this pull request as ready for review February 20, 2025 16:34
@anaivanov anaivanov requested a review from a team as a code owner February 20, 2025 16:34
Copy link
Contributor

@kgeckhart kgeckhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@anaivanov anaivanov requested a review from yduartep February 21, 2025 09:36
Copy link
Contributor

@yduartep yduartep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anaivanov anaivanov changed the title feat: add serviceId label to alerts feat: add serviceId label to csp-mixin alerts Feb 21, 2025
@anaivanov anaivanov merged commit d2fe0ae into master Feb 21, 2025
5 checks passed
@anaivanov anaivanov deleted the ana/add-serviceId-to-alerts branch February 21, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants