Skip to content

Go to definition: Function parameters #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

julienduchesne
Copy link
Collaborator

This adds support to go to definition for any parameter used within a function
Closes #14

This adds support to go to definition for any parameter used within a function
Closes #14
@julienduchesne julienduchesne marked this pull request as ready for review December 23, 2021 20:08
@zzehring
Copy link
Contributor

zzehring commented Dec 23, 2021

Nice feature! I do wonder if it would be worth having something like a findParamById function. If that's too much of a rearchitect (since it looks like we're relying on on the findBind func for both binds and params), I'll approve this PR.

@julienduchesne
Copy link
Collaborator Author

Nice feature! I do wonder if it would be worth having something like a findParamById function. If that's too much of a rearchitect (since it looks like we're relying on on the findBind func for both binds and params), I'll approve this PR.

I do agree that a refactor would be nice. I'd like to start by moving stuff out of the server package though

@julienduchesne julienduchesne merged commit ca2d383 into main Dec 29, 2021
@julienduchesne julienduchesne deleted the julienduchesne/function-parameters branch September 7, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition: Jump to parameters
2 participants