[grafana] Image Pull Secrets for the Image Renderer deployment not set in values.yaml #3653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eRenderer.image.pullSecrets' + 'imageRenderer.image.pullSecrets' is added to the values.yaml Signed-off-by: RaphSku <rapsku.dev@gmail.com>
RaphSku
requested review from
Xtigyro,
jkroepke,
maorfr and
torstenwalter
as code owners
|
|
jkroepke
requested changes
Apr 15, 2025
RaphSku
changed the title
…ets of the imageRenderer Signed-off-by: RaphSku <rapsku.dev@gmail.com>
jkroepke
approved these changes
Apr 15, 2025
jkroepke
reviewed
Apr 15, 2025
| | `imageRenderer.image.repository` | image-renderer Image repository | `grafana/grafana-image-renderer` | | ||
| | `imageRenderer.image.tag` | image-renderer Image tag | `latest` | | ||
| | `imageRenderer.image.sha` | image-renderer Image sha (optional) | `""` | | ||
| | `imageRenderer.image.pullSecrets` | image-renderer Image pull secrets (optional) | `[]` | |
There was a problem hiding this comment.
Suggested change
| | `imageRenderer.image.pullSecrets` | image-renderer Image pull secrets (optional) | `[]` | | |
| | `imageRenderer.image.pullSecrets` | image-renderer Image pull secrets (optional) | `[]` | |
|
This PR might be very tough to merge. Sad you disabled access for repo maintainers on the branch, but the repo requires an up2date branch - which is hard, since we have a mono repo for multiple helm charts here. |
Sheikh-Abubaker
approved these changes
Apr 15, 2025
@jkroepke Sorry, I activated it again, does it work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both remediations in the linked issue.
Closes #3652
Included: