[v11.2.x] Azure Monitor: Add a feature flag to toggle user auth for Azure Monitor only #97565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or only (#96858) * Azure Monitor: Add a feature flag to toggle user auth for Azure Monitor only * Fix condition for userIdentityEnabled * Re-add removed test * Remove unused prop * Refactor onAuthTypeChange in AzureCredentialsForm * Add frontend unit tests * Lint (cherry picked from commit b898a45) # Conflicts: # docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md # packages/grafana-data/src/types/featureToggles.gen.ts # pkg/services/featuremgmt/registry.go # pkg/services/featuremgmt/toggles_gen.csv # pkg/services/featuremgmt/toggles_gen.go # pkg/services/featuremgmt/toggles_gen.json
aangelisc
added
type/docs
aangelisc
requested review from
bossinc,
adamyeats,
katebrenner and
alyssabull
and removed request for
a team
adamyeats
approved these changes
Dec 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b898a45 from #96858
What is this feature?
This PR allows Grafana operators to enable or disable Azure Monitor user-based authentication independently from other Azure data sources.
A new feature toggle
azureMonitorEnableUserAuthhas been introduced within theconfig.featureTogglesobject.The feature toggle is checked alongside the existing configuration options (
config.azure.userIdentityEnabled) to determine if user-based authentication for Azure Monitor is available.Which issue(s) does this PR fix?:
Fixes #96650.