Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.0.x] AzureMonitor: Deduplicate resource picker rows #93703

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

grafana-delivery-bot[bot]
Copy link
Contributor

Backport 76c8975 from #93129


When expanding resource group rows, the original resource query used the row ID rather than the URI. The row ID only includes the resource group name and this can lead to issues when retrieving resources for two reasons:

  • Resource group names are not unique across multiple subscriptions
  • Resource group names may share prefixes e.g. dev-1, dev-12 leading to resources from dev-12 being returned when querying dev-1.

The logic has been updated to use the full resource URI in the query now to ensure that the returned results are deduplicated across subscriptions. A / is also appended to ensure that resources from resource groups sharing a naming convention or prefix will not be returned.

Fixes #92154

* Use URI for querying resources in RG

- Ensure resource group names are correctly slash separated

* Update test

(cherry picked from commit 76c8975)
@grafana-delivery-bot grafana-delivery-bot bot requested a review from a team as a code owner September 24, 2024 17:46
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.0.x milestone Sep 24, 2024
@grafana-delivery-bot grafana-delivery-bot bot requested review from bossinc, aangelisc, adamyeats and alyssabull and removed request for a team September 24, 2024 17:46
@aangelisc aangelisc enabled auto-merge (squash) September 25, 2024 09:47
@aangelisc aangelisc merged commit e055768 into v11.0.x Sep 25, 2024
20 checks passed
@aangelisc aangelisc deleted the backport-93129-to-v11.0.x branch September 25, 2024 09:47
@Sergej-Vlasov Sergej-Vlasov modified the milestones: 11.0.x, 11.0.6 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants