Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Expose datasources as apiservers feature toggle #93250

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Plugins: Expose datasources as apiservers feature toggle #93250

merged 7 commits into from
Sep 19, 2024

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Sep 12, 2024 •
edited
Loading

This PR updates the api registration logic so that datasourceAPIServers will expose:

  • grafana-testdata-datasource
  • prometheus
  • graphite

as apiservers. When running with grafanaAPIServerWithExperimentalAPIs all datasources will be exposed.

In cloud, this will add a parallel route in our single-tenant grafana instances that can access:

  • health
  • query
  • resources

Locally (with gdev installed):

http://localhost:3000/apis/testdata.datasource.grafana.app/v0alpha1/namespaces/default/connections

Once this is merged, we can update the cloud datasource dashboards to collect logs/metrics from these endpoints

@ryantxu ryantxu added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 12, 2024
@ryantxu ryantxu requested review from grafanabot and a team as code owners September 12, 2024 07:42
@github-actions github-actions bot added this to the 11.3.x milestone Sep 12, 2024
@grafana-pr-automation grafana-pr-automation bot added type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project area/frontend area/backend labels Sep 12, 2024
@ryantxu
Copy link
Member Author

ryantxu commented Sep 12, 2024

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with expose-datasources-as-apiserver-feature-flag oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

andresmgot
andresmgot reviewed Sep 12, 2024
View reviewed changes
pkg/registry/apis/datasource/register.go Outdated Show resolved Hide resolved
pkg/registry/apis/datasource/register.go Outdated Show resolved Hide resolved
pkg/registry/apis/datasource/register.go Outdated Show resolved Hide resolved
@andresmgot andresmgot mentioned this pull request Sep 12, 2024
Merged
andresmgot
andresmgot approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM After rebasing

@ryantxu ryantxu enabled auto-merge (squash) September 18, 2024 09:25
@ryantxu
Copy link
Member Author

ryantxu commented Sep 18, 2024

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with expose-datasources-as-apiserver-feature-flag oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@ryantxu ryantxu enabled auto-merge (squash) September 19, 2024 08:24
@ryantxu ryantxu merged commit f21a598 into main Sep 19, 2024
22 checks passed
@ryantxu ryantxu deleted the expose-datasources-as-apiserver-feature-flag branch September 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

@marefr marefr Awaiting requested review from marefr

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
area/backend area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Milestone
11.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ryantxu @andresmgot