Elasticsearch: Decouple backend from infra/http #90408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvrzm
force-pushed
the
njvrzm/decouple-elasticsearch-infra-http
branch
from
ccd9e95 to
f0978d7
Compare
njvrzm
changed the title
njvrzm
force-pushed
the
njvrzm/decouple-elasticsearch-infra-http
branch
from
f0978d7 to
eb789eb
Compare
|
Just letting you know that we'll be looking at these PRs shortly. |
|
Locally tested all the individual PRs and found no obvious issues. |
giorgioatmerqury
pushed a commit
to cybermerqury/grafana
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the Elasticsearch datasource's dependency on
infra/http.This is the first of three PRs to decouple the Elasticsearch plugin from core grafana imports, part of #72632. For ease of review I've split this into several PRs and targeted them as a chain (
main <- PR 1 <- PR 2 <- PR 3) but I'll rebase and retarget them as each is merged in turn.Why do we need this feature?
Removing core imports is part of the process of externalizing the plugin. See #72632 for more information.