Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User: add second migration for lowercasing login/email of users #88915

Conversation

eleijonmarck
Copy link
Contributor

@eleijonmarck eleijonmarck commented Jun 7, 2024

why
CaseInsensitiveLogin is semi broken in v11.0.x for external auth. Using auth_proxy

We need to add this migration to main, to be able to backport this change into v11.0.x. In the backport we include the lower case change on insert.

what
Adds a second migration of lower casing users email and login.

@eleijonmarck eleijonmarck added no-changelog Skip including change in changelog/release notes backport v11.0.x Mark PR for automatic backport to v11.0.x labels Jun 7, 2024
@eleijonmarck eleijonmarck added this to the 11.1.x milestone Jun 7, 2024
@eleijonmarck eleijonmarck self-assigned this Jun 7, 2024
@eleijonmarck eleijonmarck requested a review from a team as a code owner June 7, 2024 12:41
@eleijonmarck eleijonmarck requested review from zserge and removed request for a team June 7, 2024 12:41
@grafana grafana deleted a comment from grafana-delivery-bot bot Jun 7, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@eleijonmarck eleijonmarck requested a review from kalleep June 7, 2024 13:03
@eleijonmarck eleijonmarck merged commit 39bd13f into main Jun 7, 2024
31 of 32 checks passed
@eleijonmarck eleijonmarck deleted the eleijonmarck/caseinsensitive/lowercasing-second-migration-fix-for-creating-users branch June 7, 2024 13:07
eleijonmarck added a commit that referenced this pull request Jun 7, 2024
eleijonmarck added a commit that referenced this pull request Jun 10, 2024
…sers (#88917)

User: add second migration for lowercasing login/email of users (#88915)

(cherry picked from commit 39bd13f)

Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend/db/migration area/backend backport v11.0.x Mark PR for automatic backport to v11.0.x no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants