Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Improve plugin installer error messages #34437

Merged
merged 8 commits into from
May 20, 2021
Merged

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented May 19, 2021

No description provided.

@wbrowne wbrowne self-assigned this May 20, 2021
@wbrowne wbrowne requested a review from marefr May 20, 2021 08:45
@wbrowne wbrowne marked this pull request as ready for review May 20, 2021 08:45
@wbrowne wbrowne requested a review from a team as a code owner May 20, 2021 08:45
@wbrowne wbrowne requested review from aknuds1 and removed request for a team May 20, 2021 08:45
@wbrowne
Copy link
Member Author

wbrowne commented May 20, 2021

@marefr I think this is an improvement - WDYT? I've moved the extra info to a debug log instead, which may come in useful when using the CLI. For example (debug lines in blue/purple):

Screenshot 2021-05-20 at 10 18 59

Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement 👍

@wbrowne wbrowne added this to the 8.0.0-beta3 milestone May 20, 2021
@wbrowne wbrowne added the old backport v8.0.x Mark PR for automatic backport to v8.0.x label May 20, 2021
@wbrowne wbrowne merged commit c4dcfde into main May 20, 2021
@wbrowne wbrowne deleted the fix-404-plugin-message branch May 20, 2021 13:11
grafanabot pushed a commit that referenced this pull request May 20, 2021
* fix and improve error messages

* enrich error message

* ignore previous changes

* revert manual version bump

* remove condition

* fix version param

(cherry picked from commit c4dcfde)
wbrowne added a commit that referenced this pull request May 20, 2021
* fix and improve error messages

* enrich error message

* ignore previous changes

* revert manual version bump

* remove condition

* fix version param

(cherry picked from commit c4dcfde)

Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants