Access control: expose permissions to the frontend #32954
Conversation
alexanderzobnin
force-pushed
the
access-control-expose-permissions-to-frontend
branch
from
90bba80 to
9eff344
Compare
alexanderzobnin
requested review from
a team,
aknuds1,
marefr,
torkelo and
jackw
and removed request for
a team
…se-permissions-to-frontend
alexanderzobnin
changed the title
| @@ -46,6 +46,7 @@ export interface FeatureToggles { | |||
| live: boolean; | |||
| ngalert: boolean; | |||
| panelLibrary: boolean; | |||
| accesscontrol: boolean; | |||
There was a problem hiding this comment.
| accesscontrol: boolean; | |
| accessControl: boolean; |
I think we'd be consistent with casing. Also shouldn't it be down under the enterprise feature toggles?
There was a problem hiding this comment.
Hm, maybe. But right now we have feature toggle called accesscontrol. So I'd preffer to fix it in another PR.
| @@ -57,6 +57,7 @@ export class GrafanaBootConfig implements GrafanaConfig { | |||
| ngalert: false, | |||
| panelLibrary: false, | |||
| reportVariables: false, | |||
| accesscontrol: false, | |||
There was a problem hiding this comment.
| accesscontrol: false, | |
| accessControl: false, |
| * action: { scope: scope } | ||
| * } | ||
| */ | ||
| export type UserPermission = { |
There was a problem hiding this comment.
Should this be in the "app/types" instead?
There was a problem hiding this comment.
Yes, makes sense to move.
| return !!( | ||
| this.user.permissions && | ||
| this.user.permissions[action] && | ||
| (scope ? this.user.permissions[action][scope] : true) | ||
| ); |
There was a problem hiding this comment.
| return !!( | |
| this.user.permissions && | |
| this.user.permissions[action] && | |
| (scope ? this.user.permissions[action][scope] : true) | |
| ); | |
| return !!(this.user.permissions?.[action] && (scope ? this.user.permissions[action][scope] : true)); |
There was a problem hiding this comment.
This is how prettier formats this.
There was a problem hiding this comment.
This is not about formatting, you can remove an extra this.user.permissions check with the optional chaining operator.
There was a problem hiding this comment.
Got it. Did it before, but had some linter errors. Will try again.
alexanderzobnin
deleted the
access-control-expose-permissions-to-frontend
branch
|
🎉 🕺 |
This PR exposes permissions assigned to user to the frontend inside a
bootDataobject. Then permissions can be checked with theContextSrv(hasPermission()method) in the runtime. Then we can change a way how we render components depending on required access (render only if user have access, show info banner, disable action buttons, etc).