Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth: custom username docs #28400

Merged
merged 8 commits into from
Feb 4, 2021
Merged

OAuth: custom username docs #28400

merged 8 commits into from
Feb 4, 2021

Conversation

alexanderzobnin
Copy link
Contributor

This PR contains docs for the #28286 - name_attribute_path config option.

@alexanderzobnin alexanderzobnin requested review from aknuds1 and wbrowne and removed request for a team October 20, 2020 12:37
@alexanderzobnin alexanderzobnin added the type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project label Oct 20, 2020
@@ -80,6 +80,10 @@ Customize user login using `login_attribute_path` configuration option. Order of

You can customize the attribute name used to extract the ID token from the returned OAuth token with the `id_token_attribute_name` option.

You can set the user's display name with JMESPath using the `name_attribute_path` configuration option. It operates the same way as the `login_attribute_path` option.

> **Note:** `name_attribute_path` is available in Grafana 7.4+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding 7.4 docs before we have even finished 7.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this feature in 7.4, not 7.3, because it's a feature and we already pushed 7.3 beta. So we don't want to merge this before 7.3 stable released.

@alexanderzobnin alexanderzobnin added this to the 7.4 milestone Oct 20, 2020
@stale
Copy link

stale bot commented Nov 8, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Nov 8, 2020
@aknuds1 aknuds1 removed the stale Issue with no recent activity label Nov 11, 2020
…me-docs

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@stale
Copy link

stale bot commented Nov 27, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Nov 27, 2020
@aknuds1 aknuds1 removed the stale Issue with no recent activity label Nov 29, 2020
@aknuds1
Copy link
Contributor

aknuds1 commented Nov 29, 2020

Shall we merge this @alexanderzobnin?

@alexanderzobnin
Copy link
Contributor Author

@aknuds1 we're waiting for 7.4.0-beta

@aknuds1
Copy link
Contributor

aknuds1 commented Dec 1, 2020

@alexanderzobnin Ah...

@stale
Copy link

stale bot commented Dec 19, 2020

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale Issue with no recent activity label Dec 19, 2020
@mjseaman mjseaman removed this from the 7.4.0 milestone Jan 8, 2021
@stale stale bot removed the stale Issue with no recent activity label Jan 8, 2021
@mjseaman mjseaman added this to the 7.4.0 milestone Jan 8, 2021
@ivanahuckova ivanahuckova merged commit b335a59 into master Feb 4, 2021
@ivanahuckova ivanahuckova deleted the oauth-custom-username-docs branch February 4, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants