Docs: Alerting Notifications - make last three sections show on online docs #23587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last three sections of this document are not rendered on https://grafana.com/docs/grafana/latest/alerting/notifications It seems like in all other instances (other .md docs of this project), level one headers are only used at the top of the page, so I assume using level two headers will make them show. Level two headers do also match the overall structure of the documentation.
|
|
|
So, I have not actually checked that my change fixes the issue reported since I don't know how to do that. Nonetheless the document structure seem to imply that these headers should be level two so the pull request should still be valid 😃 |
|
If you want to test it out there is a short guide for how you can start the docs site locally using docker |
oddlittlebird
approved these changes
Apr 15, 2020
aknuds1
added
pr/external
bergquist
added a commit
that referenced
this pull request
Apr 17, 2020
* master: (139 commits) SAML Role and Team sync (open source part) (#23391) Transformers: fixes column names generated by seriesToColumn transformer (#23642) Table: add a select option when multiple tables exist (#23545) Tabs: adds counter component (#23548) UX: Minor style tweaks and fixes (#23614) Modals: Fixed alignment in header (#23618) revent optional event arg change (#23622) Build: Stricter linting should break the build (#23606) Docs: update users API (#23570) Explore: Prevents sizing issue when split (#23596) @grafana/ui: Various smaller Icon updates (#23588) Because alpine uses musl instead of libc, the e2e/cypress was not compatible (#23602) Backend Plugins: Discard logged messages from logger named stdio (#23601) Fixed share json (#23607) Linting fixes for provisoning (#23600) Image Rendering: Remove PhantomJS support (#23460) Storybook: Organizing (#23572) @grafana/ui: Remove ColorPallete component (#23592) Docs: Change header levels of last three sections (#23587) CircleCI: Upgrade the build pipeline tool (#23595) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The last three sections of this document are not rendered on grafana.com/docs. It seems like in all other instances (other .md docs of this project), level one headers are only used at the top of the page, so I assume using level two headers will make them show. Level two headers do also match the overall structure of the documentation.
Which issue(s) this PR fixes:
Fixes #23584
Special notes for your reviewer: