Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update grafana-plugin-sdk-go to latest #1702

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

zoltanbedi
Copy link
Member

Updates grafana-plugin-sdk-go to latest so we will get rid of the last vulnerability issue. Also run go mod tidy.

@zoltanbedi zoltanbedi requested a review from a team as a code owner October 4, 2023 15:22
@zoltanbedi zoltanbedi requested review from gabor and gwdawson and removed request for a team October 4, 2023 15:22
@zoltanbedi zoltanbedi self-assigned this Oct 4, 2023
@@ -43,7 +43,7 @@ func NewZabbixDatasource() *ZabbixDatasource {
}

// newZabbixDatasourceInstance returns an initialized zabbix datasource instance
func newZabbixDatasourceInstance(dsSettings backend.DataSourceInstanceSettings) (instancemgmt.Instance, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a breaking change in the plugin sdk.https://github.com/grafana/grafana-plugin-sdk-go/releases/tag/v0.177.0

Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zoltanbedi zoltanbedi merged commit f31fc80 into master Oct 5, 2023
3 checks passed
@zoltanbedi zoltanbedi deleted the zoltan/update-sdk-go branch October 5, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants