Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow: Update arrow to v16 #999

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Arrow: Update arrow to v16 #999

wants to merge 1 commit into from

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Jun 4, 2024

What this PR does / why we need it:

This PR updates the arrow library (and parquet support) to the latest v16 release. v16 has improved parquet support (now with full metadata)

UPDATE...

waiting for https://lists.apache.org/thread/fstyfvzczntt9mpnd4f0b39lzb8cxlyf to play out and then update. Looks like that process will require code changes once, but then way less frequently

@ryantxu ryantxu added the arrow https://godoc.org/github.com/apache/arrow/go/arrow label Jun 4, 2024
@ryantxu ryantxu requested review from a team as code owners June 4, 2024 10:31
@ryantxu ryantxu requested review from wbrowne, marefr and oshirohugo and removed request for a team June 4, 2024 10:31
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ryan McKinley seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ryan McKinley seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the binary format is compatible LGTM, but would be good with some input from @grafana/data-plane-wg since they own the data package

@ryantxu
Copy link
Member Author

ryantxu commented Jun 5, 2024

ugg -- the dependency in https://github.com/scottlepp/go-duck/blob/main/go.mod#L8 -- make our deployment here more difficult. So this may take a while 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow https://godoc.org/github.com/apache/arrow/go/arrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants