Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for flag overrides using environment variables #691

Merged
merged 1 commit into from
Feb 22, 2022
Merged

feat: added support for flag overrides using environment variables #691

merged 1 commit into from
Feb 22, 2022

Conversation

kschjeld
Copy link

Description

Added support for overriding Grafana image/tag and plugins image/tag through environment variables.

This is needed to allow configuration overrides when installing the operator in OpenShift 4.x using OLM, as the Subscription resource doesn't allow for adding command line arguments to the deployed operator.

Type of change

  • [x ] New feature (non-breaking change which adds functionality)

Checklist

  • [ x] This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

In OpenShift when deploying using Subscription, add a section as follows:

 config:
    env:
    - name: GRAFANA_IMAGE_URL
      value: someregistry.com/somegrafana

Verify that the Grafana deployments created uses the specified container image url.

Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! thanks for addressing this, and the neat documentation to go along with it :) @pb82 @NissesSenap thoughts?

@pb82 pb82 merged commit ad25aae into grafana:master Feb 22, 2022
@pb82
Copy link
Collaborator

pb82 commented Feb 22, 2022

thanks @kschjeld

@kschjeld kschjeld deleted the feature/olm-support branch February 22, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants