feat: add HTTPSProxy to env var

[hubeadmin]

Description

• adds new configuration options for secure http proxy env vars to be used when downloading plugins

Relevant issues/tickets

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• This change requires a documentation update
• I have added tests that prove my fix is effective or that my feature works
• I have added a test case that will be used to verify my changes
• Verified independently on a cluster by reviewer

Verification steps

[hubeadmin]

#676 @bukovjanmic can you take a look at this and see if this fixes your issue?

[bukovjanmic]

Looking at the PR, it seems this would fix the problem.

Although maybe unnecessarily complicated, I would leave out the Secure parametr and leave only URL and secureURL params. If URL is non-empty (and proxy enabled), HTTP_PROXY is generated. If secureURL is non-empty, HTTPS_PROXY is enabled.

Maybe another thought - since the plugins are always downloaded from https (it is hardcoded in the plugin image, I believe), we always need HTTPS_PROXY, so it should be either mentioned in documentation or maybe an error should be printed out if a plugin needs to be downloaded and secureURL is not defined.

Also, it would be nice if the pkugins could be cached in a PVC (e.g. enable PVC mount to plugin downloader and skip download if plugins are already present there. This would result in faster startup and also safer, as Grafana would start even if proxy or outside internet connection is not available. But I guess this is for a different issue.

Thanks,

Michal

[hubeadmin]

Looking at the PR, it seems this would fix the problem.

Although maybe unnecessarily complicated, I would leave out the Secure parametr and leave only URL and secureURL params. If URL is non-empty (and proxy enabled), HTTP_PROXY is generated. If secureURL is non-empty, HTTPS_PROXY is enabled.

Maybe another thought - since the plugins are always downloaded from https (it is hardcoded in the plugin image, I believe), we always need HTTPS_PROXY, so it should be either mentioned in documentation or maybe an error should be printed out if a plugin needs to be downloaded and secureURL is not defined.

Also, it would be nice if the pkugins could be cached in a PVC (e.g. enable PVC mount to plugin downloader and skip download if plugins are already present there. This would result in faster startup and also safer, as Grafana would start even if proxy or outside internet connection is not available. But I guess this is for a different issue.

Thanks,

Michal

@bukovjanmic thanks for the feedback, I'll get back on this ASAP, as for the PVC cache, yeah I would consider that a separate issue

[hubeadmin]

@bukovjanmic How does this update look? If you'd like me to, I can generate an operator image and some manifests for you to try it out on your setup?

[bukovjanmic]

Yes, looks good.

If there is an image, I can test it, as there is a way to override default image.