Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using leader-elect, use deployment recreate #638

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

NissesSenap
Copy link
Collaborator

@NissesSenap NissesSenap commented Nov 30, 2021

Description

Solves #629, currently leader-elect is broken so for now we disable it.
In the future we will most likley re-enable it again.

Relevant issues/tickets

#629
#631
#620

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  • k apply -k deploy/manifests
  • Wait and see that the operator starts
  • Update the deployment, for example set log level to debug in deploy/manifests/latest/deployment.yaml
  • k apply -k deploy/manifests

The operator will be recreated without any issues and won't complain about missing node access.

Solves grafana#629, currently leader-elect is broken so for now we disable it.
In the future we will most likley re-enable it again.
@NissesSenap
Copy link
Collaborator Author

I have verified l locally using make bundle and I can see that this change will also hit on the generated OLM yaml.

Copy link
Collaborator

@pb82 pb82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pb82 pb82 merged commit 9c262cd into grafana:master Nov 30, 2021
@NissesSenap NissesSenap deleted the disable_leader branch March 2, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants