Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC add possability to patch events #634

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

NissesSenap
Copy link
Collaborator

Description

This way --scan-all don't have to add any custom clusterroles.
Solves #630

Relevant issues/tickets

#630

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

You shouldn't see any errors.

@NissesSenap
Copy link
Collaborator Author

In v4 we have gone over to using cluster roles instead of roles to create access. This is much due to OLM will shift towards only using cluster wide operators.
It's also a premature preparation for multi-namespace support. If we add this patch I think we can remove https://github.com/grafana-operator/grafana-operator/tree/master/deploy/cluster_roles all together since all the needed access should be set.

This rule is probably needed for a single namespace as well and when we have done our testing we probably haven't updated our dashboards enough to find the issue.

This way --scan-all don't have to add any custom clusterroles.
Solves grafana#630
@pb82 pb82 merged commit 64685c6 into grafana:master Nov 30, 2021
@NissesSenap NissesSenap deleted the event_patch branch November 30, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants