Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare release v4.0.1 #558

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Oct 12, 2021

Description

Prepare the v4.0.1 release, a bugfix for the broken v4.0.0 release.

The following catalog source can be used to install the Operator from OLM:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: grafana-operator-manifests
  namespace: grafana
spec:
  sourceType: grpc
  image: quay.io/grafana-operator/controller-index:v4.0.1

@pb82 pb82 requested a review from hubeadmin October 12, 2021 10:08
@pb82 pb82 added the v4 Major version 4 label Oct 12, 2021
@hubeadmin
Copy link
Collaborator

getting a nil pointer exception when applying datasources on a fresh install

E1012 15:16:58.902585  290186 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
goroutine 1954 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x1658220, 0x23e19a0)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/runtime/runtime.go:74 +0x95
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/runtime/runtime.go:48 +0x86
panic(0x1658220, 0x23e19a0)
	/usr/lib/golang/src/runtime/panic.go:965 +0x1b9
github.com/integr8ly/grafana-operator/controllers/grafanadatasource.(*GrafanaDatasourceReconciler).manageSuccess(0xc0002ab720, 0xc00031a580, 0x3, 0x4)
	/home/hstefans/go/src/github.com/grafana-operator/grafana-operator/controllers/grafanadatasource/datasource_controller.go:230 +0x2c9
github.com/integr8ly/grafana-operator/controllers/grafanadatasource.(*GrafanaDatasourceReconciler).reconcileDataSources(0xc0002ab720, 0xc000d3bbe8, 0xc000a4f620, 0x1a48540)
	/home/hstefans/go/src/github.com/grafana-operator/grafana-operator/controllers/grafanadatasource/datasource_controller.go:160 +0x809
github.com/integr8ly/grafana-operator/controllers/grafanadatasource.(*GrafanaDatasourceReconciler).Reconcile(0xc0002ab720, 0x1a36418, 0xc000a4f620, 0xc000f42f39, 0x7, 0xc001302000, 0x17, 0xc000a4f620, 0xc000032000, 0x16e1620, ...)
	/home/hstefans/go/src/github.com/grafana-operator/grafana-operator/controllers/grafanadatasource/datasource_controller.go:84 +0x185
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc0002b1ae0, 0x1a36370, 0xc00071c900, 0x16a88a0, 0xc00043a300)
	/home/hstefans/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:298 +0x30d
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc0002b1ae0, 0x1a36370, 0xc00071c900, 0xc0008a8e00)
	/home/hstefans/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:253 +0x205
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2(0x1a36370, 0xc00071c900)
	/home/hstefans/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:216 +0x4a
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1()
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185 +0x37
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0xc0008a8f50)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:155 +0x5f
k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000d3bf50, 0x1a05220, 0xc0001d8a50, 0xc00071c901, 0xc00001d380)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:156 +0x9b
k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc0008a8f50, 0x3b9aca00, 0x0, 0xbfc701, 0xc00001d380)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:133 +0x98
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext(0x1a36370, 0xc00071c900, 0xc0004c84c0, 0x3b9aca00, 0x0, 0x1)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185 +0xa6
k8s.io/apimachinery/pkg/util/wait.UntilWithContext(0x1a36370, 0xc00071c900, 0xc0004c84c0, 0x3b9aca00)
	/home/hstefans/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:99 +0x57
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
	/home/hstefans/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:213 +0x40d
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x14df2e9]

will look into this a bit more

@pb82 pb82 force-pushed the prepare-release-4.0.1 branch from 6be77c4 to 89a1ede Compare October 18, 2021 19:28
@pb82
Copy link
Collaborator Author

pb82 commented Oct 18, 2021

@HubertStefanski the exception on datasource creation should be fixed now

@pb82 pb82 force-pushed the prepare-release-4.0.1 branch from 89a1ede to a848388 Compare October 18, 2021 19:31
Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The issue has been fixed and dashboards/datasources are successfully created

@pb82 pb82 merged commit 8225cdc into grafana:master Oct 19, 2021
@pb82 pb82 deleted the prepare-release-4.0.1 branch October 19, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Major version 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants