-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from 3.x.x to 4.0.0 #482
Conversation
|
||
# OLM | ||
bundle | ||
config/manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry. I had to make changes to those files and I think they should be in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@pb82 Are you going to do TODO's in this PR as well?
Tried verifying but CRC keeps crashing :| I'll retry again tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always @pb82!
Found a few things that I'm wondering about.
Except the files already changed I think we should remove grafana-operator v3 specific stuff like:
https://github.com/grafana-operator/grafana-operator/blob/master/deploy/operator.yaml
Or if not remove at least rename the folder to v3 or legacy to naturally point people to V4.
Or do we want to use those files for deployment in the future as well? Would could write a small shell script that generates the files using kustomize build command.
Depending on what we choose here we need to update the docs as well.
bundle/manifests/grafana-operator-controller-manager-metrics-service_v1_service.yaml
Show resolved
Hide resolved
93c5949
to
9ff7641
Compare
1654911
to
4d90d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade documentation thoughts:
4d90d97
to
7362256
Compare
@NissesSenap @HubertStefanski all feedback addressed, are you ok to merge this? |
LGTM |
Description
Changes required to release 4.0.0, and make it work via OLM. This should also contain the migration guide from 3.x.x to 4.0.0.
CRDs are upgraded to v1 (from v1alpha1).
TODO
Verification steps
The following CatalogSource can be used to install 4.0.0 via OLM: