chore(Config): Migrate ENV vars to kong #2380
Open
+65
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
chore_convert_env_vars_to_kong
branch
2 times, most recently
from
52be944 to
16a45f1
Compare
Baarsgaard
force-pushed
the
chore_convert_env_vars_to_kong
branch
2 times, most recently
from
9fb88ff to
fd15765
Compare
Baarsgaard
force-pushed
the
chore_convert_env_vars_to_kong
branch
2 times, most recently
from
84462a7 to
1d1d4d1
Compare
Baarsgaard
requested review from
hubeadmin,
ishanjainn,
nissessenap,
pb82,
theSuess and
weisdd
as code owners
weisdd
reviewed
Dec 23, 2025
| cl, err := client.New(restConfig, client.Options{}) | ||
| if err != nil { | ||
| setupLog.Error(err, "Failed to get watch namespaces") | ||
| setupLog.Error(err, "failed to get watch namespaces") |
Collaborator
There was a problem hiding this comment.
Since you're already touching this code, I think we should fix the error message here. E.g. "failed to create a Kubernetes client".
weisdd
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
WATCH_LABEL_SELECTORWill now exit if the selector cannot be parsedENFORCE_CACHE_LABELSis now validated by a Kong enum.Removed the switch that effectively set a bool to
trueto enable cachingWATCH_NAMESPACE_SELECTOR, now returns an error when invalidFor now the changes have been tested manually, but further refactoring is planned.
Specifically to move logic out of main and into functions to allow for testing, maybe even with
envtest