Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support stackdriver datasource options #225

Merged
merged 1 commit into from
Jul 17, 2020
Merged

support stackdriver datasource options #225

merged 1 commit into from
Jul 17, 2020

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Jul 17, 2020

fixes #220

Adds datasource jsonData and secureJsonData options to support stackdriver. Also adds an example DS.

@pb82 pb82 requested a review from hubeadmin July 17, 2020 08:41
@pb82 pb82 mentioned this pull request Jul 17, 2020
Closed
@pb82 pb82 force-pushed the support-stackdriver-ds branch from 461de16 to ec329e0 Compare July 17, 2020 08:49
@pb82 pb82 force-pushed the support-stackdriver-ds branch from ec329e0 to fb9f3ab Compare July 17, 2020 08:49
@hubeadmin hubeadmin added the bugfix this PR fixes a bug label Jul 17, 2020
@hubeadmin
Copy link
Collaborator

Going to do a quick verification before approving @pb82 @markusjevringsesame

hubeadmin
hubeadmin approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Fields appear in the datasource CR on the cluster as they should

@pb82 pb82 merged commit df33ded into grafana:master Jul 17, 2020
@pb82 pb82 deleted the support-stackdriver-ds branch July 17, 2020 09:08
@david-martin david-martin mentioned this pull request Oct 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusjevringsesame markusjevringsesame markusjevringsesame left review comments

@hubeadmin hubeadmin hubeadmin approved these changes

Assignees
No one assigned
Labels
bugfix this PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Stackdriver datasources not imported correctly
3 participants
@pb82 @hubeadmin @markusjevringsesame